Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chapters/io: Add checker infrastructure for lab 10 #147

Merged
merged 1 commit into from
Dec 9, 2024
Merged

chapters/io: Add checker infrastructure for lab 10 #147

merged 1 commit into from
Dec 9, 2024

Conversation

Viktor09
Copy link

@Viktor09 Viktor09 commented Dec 9, 2024

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

Add checkers for lab 10

Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the checkers. Now add instructions about running the checkers along with a snippet with its output with all tests passing to each task's README.md.

@@ -22,7 +22,6 @@ void create_fifo_if_needed(void)

if (rc < 0) {
rc = unlink(fifo_path);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rc = unlink(fifo_path);
unlink(fifo_path);

@teodutu
Copy link

teodutu commented Dec 9, 2024

You haven't applied my changes yet.

Pending to get a response

Signed-off-by: Viktor09 <[email protected]>
@teodutu
Copy link

teodutu commented Dec 9, 2024

@robertpaulp please add your review.

Copy link

@robertpaulp robertpaulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. GJ!

@teodutu teodutu merged commit 706610f into main Dec 9, 2024
9 checks passed
@Alex-deVis Alex-deVis deleted the victor branch December 14, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants